QOL Thing for the Player Builder

QOL Thing for the Player Builder - Printable Version

+- Simulation Hockey League (https://simulationhockey.com)
+-- Forum: Community (https://simulationhockey.com/forumdisplay.php?fid=17)
+--- Forum: SHL Discussion (https://simulationhockey.com/forumdisplay.php?fid=49)
+---- Forum: Suggestion Box (https://simulationhockey.com/forumdisplay.php?fid=50)
+---- Thread: QOL Thing for the Player Builder (/showthread.php?tid=106717)

QOL Thing for the Player Builder - MCP_ - 05-19-2020

I noticed that for the defensive ratings on many player pages, it doesn't match the order of the player builder. Using my page as an example:

Compare that to the player builder:

[Image: 4eK7WY6.png]

Basically, just make the player builder match that of the template of a player page

RE: QOL Thing for the Player Builder - _Blitz_ - 05-19-2020

I second this.

RE: QOL Thing for the Player Builder - Samsung virtual assistant - 05-19-2020

Yeah i noticed that too, weird

RE: QOL Thing for the Player Builder - Sean - 05-19-2020

05-19-2020, 04:38 PMMCP_ Wrote: I noticed that for the defensive ratings on many player pages, it doesn't match the order of the player builder. Using my page as an example:

Compare that to the player builder:

Basically, just make the player builder match that of the template of a player page

I think the issue is the player build tool was made using the front facing order of the attributes on FHM but the order when inputting the attributes into FHM is different for some reason.

I don't know why we don't just use the back-end attribute order everywhere on the site though. I doubt most people are going into the sim and comparing their stats to what is on their player page and even so, if it's out of order for them it's just a slight inconvenience.

There's probably a bigger issue I'm missing.

RE: QOL Thing for the Player Builder - golden_apricot - 05-19-2020

05-19-2020, 04:45 PMTommySalami Wrote:
05-19-2020, 04:38 PMMCP_ Wrote: I noticed that for the defensive ratings on many player pages, it doesn't match the order of the player builder. Using my page as an example:

Compare that to the player builder:

Basically, just make the player builder match that of the template of a player page

I think the issue is the player build tool was made using the front facing order of the attributes on FHM but the order when inputting the attributes into FHM is different for some reason.

I don't know why we don't just use the back-end attribute order everywhere on the site though. I doubt most people are going into the sim and comparing their stats to what is on their player page and even so, if it's out of order for them it's just a slight inconvenience.

There's probably a bigger issue I'm missing.

yes, so teddy made this for the front end attribute order, and we switcehd the output to match the backend order so that the file workers make far fewer mistakes. We probably should swap around the order on the front of the player building tool to

RE: QOL Thing for the Player Builder - DrunkenTeddy - 05-21-2020

It's basically a bunch of work to reorganize, it's possible but hasn't been a big priority.

RE: QOL Thing for the Player Builder - DrunkenTeddy - 05-21-2020

05-21-2020, 05:33 PMDrunkenTeddy Wrote: It's basically a bunch of work to reorganize, it's possible but hasn't been a big priority.

I think I got it on the dev server, can some people go here and test for me? Tell me if you see any issues. If not I can move it to the regular site.
http://dev.simulationhockey.com/playerbuilder.php

RE: QOL Thing for the Player Builder - Carbine - 05-21-2020

05-21-2020, 06:37 PMDrunkenTeddy Wrote:
05-21-2020, 05:33 PMDrunkenTeddy Wrote: It's basically a bunch of work to reorganize, it's possible but hasn't been a big priority.

I think I got it on the dev server, can some people go here and test for me? Tell me if you see any issues. If not I can move it to the regular site.
http://dev.simulationhockey.com/playerbuilder.php

I didn't see any glaring issues just messing with it for 30 seconds Tongue

RE: QOL Thing for the Player Builder - mastersheep - 05-21-2020

Checked and it looks good to me too.

RE: QOL Thing for the Player Builder - Nhamlet - 05-22-2020

05-21-2020, 06:37 PMDrunkenTeddy Wrote:
05-21-2020, 05:33 PMDrunkenTeddy Wrote: It's basically a bunch of work to reorganize, it's possible but hasn't been a big priority.

I think I got it on the dev server, can some people go here and test for me? Tell me if you see any issues. If not I can move it to the regular site.
http://dev.simulationhockey.com/playerbuilder.php

Looks good, the goalie side change also appreciated.

RE: QOL Thing for the Player Builder - DrunkenTeddy - 05-22-2020

Now live on the regular server.